Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom SSZ beacon states route #5065

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Remove custom SSZ beacon states route #5065

merged 5 commits into from
Jan 30, 2024

Conversation

jmcph4
Copy link
Member

@jmcph4 jmcph4 commented Jan 15, 2024

Issue Addressed

Closes #5063

Proposed Changes

  • Remove get_lighthouse_beacon_states_ssz from the HTTP API
  • Remove common::eth2::BeaconNodeHttpClient::get_lighthouse_beacon_states_ssz

Additional Info

N/A

@jmcph4 jmcph4 self-assigned this Jan 15, 2024
@jmcph4 jmcph4 added work-in-progress PR is a work-in-progress do-not-merge HTTP-API backwards-incompat Backwards-incompatible API change labels Jan 15, 2024
@jmcph4 jmcph4 added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress do-not-merge labels Jan 17, 2024
@jmcph4
Copy link
Member Author

jmcph4 commented Jan 17, 2024

Remaining CI fails seem to be Redis-related so I'm pushing this to review.

@michaelsproul michaelsproul mentioned this pull request Jan 19, 2024
Closed
@chong-he chong-he mentioned this pull request Jan 23, 2024
Merged
dapplion
dapplion approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you rebase on latest unstable to re-try CI?

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 29, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Jan 29, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at abeb358

mergify bot added a commit that referenced this pull request Jan 29, 2024
@mergify
Merge of #5065
f5dae3e
This was referenced Jan 29, 2024
Closed
Merged
Merged
Merged
Merged
@mergify mergify bot merged commit abeb358 into sigp:unstable Jan 30, 2024
27 of 29 checks passed
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
@jmcph4 @danielrachi1
Remove custom SSZ beacon states route (sigp#5065)
6380e28 
* Remove SSZ state root route

* Remove SSZ states route from client impl

* Patch tests

* Merge branch 'unstable' into 5063-delete-ssz-state-route

* Further remove dead code
@chenrui333 chenrui333 mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@michaelsproul michaelsproul Awaiting requested review from michaelsproul

Assignees

@jmcph4 jmcph4

Labels
backwards-incompat Backwards-incompatible API change HTTP-API ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcph4 @michaelsproul @dapplion